https://www.howtoforge.com/community/threads/ispconfig3-billing-module-early-payment-received.70505/#post-331785

SEPA module in 1.4 release: Changing the IBAN record of our customer the payment is not set to FRST and stays RCNG.

Funktion to set User in Groups and send a mail to Group with Information. In some Situation I want only 10 users send Information about new Features or other things and not to all.

Today I can only send to one User over the Billing System or Support System .

Make "Verwendungszweck" in SEPA payments configurable.

Because of changes in additional templates handling in onsubmit() in client_edit.php between revisions

http://git.ispconfig.org/ispconfig/ispconfig3/blob/615a0a96618fa99e7e452523145d6c0f238d4473/interface/web/client/client_edit.php
http://git.ispconfig.org/ispconfig/ispconfig3/blob/7b47c0aa0aeee6f059f00008e36cc210ca89ecb9/interface/web/client/client_edit.php

function client_update() in billing_plugin_inc.php nomore works properly. The value of $page_form->dataRecord['template_additional'] is empty and is replaced by $page_form->_template_additional array which holds some additional informations. This destroys handling of additional templates in billing module. Quick patch of client_update() included below:

= $new_template_ids = $page_form->dataRecord['template_master'];
- if($page_form->dataRecord['template_additional'] != '') $new_template_ids .= '/'.trim($page_form->dataRecord['template_additional']);
+ $new_template_ids .= "/" . implode('/', $page_form->_template_additional);
+ $new_template_ids = preg_replace("/\/[^:]*:/", "/", $new_template_ids);
= $new_template_id_array = explode('/',$new_template_ids);

= $old_template_ids = $page_form->oldDataRecord['template_master'];
= if($page_form->oldDataRecord['template_additional'] != '') $old_template_ids .= '/'.trim($page_form->oldDataRecord['template_additional']);
+ $old_template_ids = preg_replace("/\/[^:]*:/", "/", $old_template_ids);
= $old_template_id_array = explode('/',$old_template_ids);

If you have customers using their EU VatID or live outside EU, you have always set the VAT rate to 0 manually if you create proforma invoices.

There should be a flag in the customer settings to exempt this customer from tax calculation.

Then it would easy to respect this setting while adding items to a new invoice.

I if you create a invoice draft the date of the invoice is set to the day the draft was created.
If later the draft will be saved as final invoice the date will not be updated.
This is not right and has led to many invalid invoices for me in the past. The invoice date must be set to the day the invoice has been finalized and the PDF was created, or the invoice was sent by mail.

An invoice item should also have a quantity type per item. e.g. hours, days, pieces. i see that there is something simliar in the item template, but the selected "hour" doesn't appear anywhere in the invoice.

Add variable for start date in recurring items text

create_recurring_invoices.php:

$trans = array( '{INVOICE_NUMBER}' => $invoice['invoice_number'],
'{INVOICE_AMOUNT}' => $app->functions->currency_format($invoice['invoice_amount'], 'client'),
'{INVOICE_CURRENCY}' => $invoice_settings['currency'],
....
'{SALUTATION}' => client_lng('salutation_'.$client['gender'].'_txt', $client['language']),



send_invoice_reminder.php, invoice_message_edit.php:
Add "client_lng" function from create_recurring_invoices.php - also add {SALUTATION} in $trans like above.


Add trans definition:
/web/billing/lib/lang/de.lng:
$wb["salutation_m_txt"] = 'Sehr geehrter Herr';
$wb["salutation_f_txt"] = 'Sehr geehrte Frau';

/web/billing/lib/lang/en.lng:
$wb["salutation_m_txt"] = 'Dear Sir';
$wb["salutation_f_txt"] = 'Dear Madam';

and so one..