Change mailbox name

There seems to be an error in the mv command of the vmail directory when changing the name of a mailbox:

Steps to reproduce:

1. Create a mailbox mbox1@domain.tld a maildir direcotry /var/vmail/domain.tld/mbox1 is created - so far so good

2. Update mailbox to mbox2@domain.tld the directory mbox1 is not renamed to mbox2 but is moved into directory mbox2 i.e. the directory structure is: /var/mail/domain.tld/mbox2/mbox1/

if the command in line 119 is changed to exec('mv -f '.escapeshellcmd(

data['old']['maildir']).'/* '.escapeshellcmd(

data['new']['maildir'])); //note the aditional / the move is executed correctly - BUT the old dir is not deleted (because the mv command does not move the "invisible" .ispconfig_mailsize rmdir() fails)

Maybe it would be a better solution to move the whole directory, instead of the content i.e. mv -f /var/mail/domain.tld/mbox1 /var/mail/domain.tld/mbox2

instead of mkdir -p /var/mail/domain.tld/mbox2 mv -f /var/mail/domain.tld/mbox1/* /var/mail/domain.tld/mbox2 rmdir(/var/mail/domain.tld/mbox1)

Cheers, David

Milestone changed to 3.0.0.9 RC2

i have add / with rev 849 and i have try it but i not found other problem, the old directory there isn't

Moving with a wildcard is not sufficient. Wildcard does not reference hidden (dot) files/folders, so if the user created any IMAP folders they will "disappear" in the move and the original folder won't be deleted.

The mailbox directory itself has to be renamed, as the original code attempted. The bug here is creating the target mailbox and then doing the move, hence it becoming a subfolder.

Maybe we need: // Move mailbox, if domain has changed if($data['new']['maildir'] != $data['old']['maildir'] && is_dir($data['old']['maildir'])) { rmdir($data['new']['maildir']); exec('mv -f '.escapeshellcmd(

data['old']['maildir']).' '.escapeshellcmd(

data['new']['maildir'])); $app->log('Moved Maildir from: '.$data['old']['maildir'].' to '.$data['new']['maildir'],LOGLEVEL_DEBUG); }

That creates the new maildir path (current code "mkdir -p", not shown), removes the new maildir folder then moves the whole old maildir to new. However it does rely on the new maildir to not have any contents from a previous account that wasn't cleaned up properly.

Part of the fix in revision r857 falls into the same trap as the original bug. It forces rm with a wildcard, which will only delete non-dot files (line 121-122), fail to remove the directory if it had subfolders or dot files and then move the old box into a subdirectory.

Suggest using recursive force rm: if(is_dir($data['new']['maildir'])) { exec("rm -Rf ".escapeshellcmd($data['new']['maildir'])); }

Status changed to closed